Skip to content

Added tslint and prettierrc#76

Open
prathambatra wants to merge 1 commit into
coding-blocks:masterfrom
prathambatra:master
Open

Added tslint and prettierrc#76
prathambatra wants to merge 1 commit into
coding-blocks:masterfrom
prathambatra:master

Conversation

@prathambatra

Copy link
Copy Markdown

Signed-off-by: prathambatra batrapratham999@gmail.com
fixes #72

Signed-off-by: prathambatra <batrapratham999@gmail.com>
@prathambatra

Copy link
Copy Markdown
Author

@jatinkatyal13 I have setup this. but on running npm lint I got lot of errors. I don't know much about prettier and linting.

@prabalsingh24

Copy link
Copy Markdown
Contributor

Are you getting errors for 'test' directory? because I have used semi colon and tabWidth = 4 in my PRs 😅 ( I realized it later :( )

@jatinkatyal13

Copy link
Copy Markdown
Contributor

That's what linting is for, yes it will have a lot of errors because the code wasn't written in a consistent manner. We should aim to have no linting errors ideally but code would function nonetheless

@prathambatra

Copy link
Copy Markdown
Author

what should i do now? all configs are fine?

@jatinkatyal13

Copy link
Copy Markdown
Contributor

LGTM!

@prathambatra

prathambatra commented May 25, 2020

Copy link
Copy Markdown
Author

travis CI build is failing

@prathambatra prathambatra marked this pull request as ready for review May 25, 2020 12:06
@prabalsingh24

prabalsingh24 commented May 26, 2020

Copy link
Copy Markdown
Contributor

travis CI build is failing

@jatinkatyal13
travis-ci is running this command
docker exec judgecompose_api_1 scripts/wait-for-it.sh -t 180 api:3737 -- npm run seedlangs
which is creating an API key before the tests begin. And because the same api key value is used here beforeEach. it is throwing an error :)

@prathambatra

Copy link
Copy Markdown
Author

@jatinkatyal13

@jatinkatyal13

Copy link
Copy Markdown
Contributor

back merge with the current Head and the test should not fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor unstructured codebase and integrate linting checks

3 participants